try object arrays for perioddata #157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Despite the challenges this presents in transformation before writing MF6 list-based input, it seems best to keep array variables separate. The fact that they are combined as records in the DFN specification is a formatting detail, not a core requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up to now the prototype has separated period data into an array for each column of the period data record (OC is a little different but same spirit). this makes unstructuring/writing to input files harder because the arrays must be recombined or cleverly indexed, and it also departs from the DFN files, which will mean we need some extra translations during codegen. try following the DFNs exactly and using arrays of object dtype. this makes indexing/etc a little more awkward. hope this helps us consider the tradeoffs and decide which approach is ideal.